Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo-xtask for automating builds #388

Closed
lrlna opened this issue Mar 29, 2021 · 1 comment · Fixed by #562
Closed

Use cargo-xtask for automating builds #388

lrlna opened this issue Mar 29, 2021 · 1 comment · Fixed by #562
Labels
feature 🎉 new commands, flags, functionality, and improved error messages maintenance 🛠️
Milestone

Comments

@lrlna
Copy link
Member

lrlna commented Mar 29, 2021

Description

Our current build.rs is handling a lot of various functionality pertaining to the release, installers and npm. To automate and test these separate pieces, we should consider switching to using [cargo-xtask](https://github.com/matklad/cargo-xtask).

I see us have a few xtasks:

  • cargo xtask npm - to generate all applicable work for our npm package
  • cargo xtask release -- to handle release management and prep
  • cargo xtask install -- to handle installations
  • maybe a few more??

Prior Art

A few good examples for us to look at:

@lrlna lrlna added feature 🎉 new commands, flags, functionality, and improved error messages maintenance 🛠️ labels Mar 29, 2021
@lrlna lrlna added this to the May 4 milestone Mar 29, 2021
@lrlna lrlna modified the milestones: May 11, May 25 Apr 8, 2021
@EverlastingBugstopper
Copy link
Contributor

cargo xtask dist seems to be the pattern for making release stuff happen, and cargo xtask ci could include running our clippy + tests stuff, everything currently in lint.yml could be slurped up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages maintenance 🛠️
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants