Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rethink config show #274

Closed
EverlastingBugstopper opened this issue Feb 16, 2021 · 0 comments · Fixed by #323
Closed

rethink config show #274

EverlastingBugstopper opened this issue Feb 16, 2021 · 0 comments · Fixed by #323
Assignees
@EverlastingBugstopper
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Milestone
March 9

Comments

@EverlastingBugstopper
Copy link
Contributor

should it still exist alongside whoami? maybe we add the --sensitive flag to the whoami command to show the actual key?

if we end up keeping it around, maybe we should make the profile name a --profile <name> flag like everywhere else instead of a positional [name]
@EverlastingBugstopper EverlastingBugstopper changed the title rethink profile show rethink config show Feb 17, 2021
@lrlna lrlna added the feature 🎉 new commands, flags, functionality, and improved error messages label Feb 19, 2021
@lrlna lrlna added this to the 0.0.5 milestone Feb 19, 2021
Merged
@EverlastingBugstopper EverlastingBugstopper self-assigned this Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EverlastingBugstopper EverlastingBugstopper

Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Milestone
March 9
Development

Successfully merging a pull request may close this issue.

feat: squash config show into config whoami apollographql/rover
2 participants
@lrlna @EverlastingBugstopper