Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for TTY before prompting in rover template use #1395

Open
dbanty opened this issue Nov 2, 2022 · 0 comments
Open

Check for TTY before prompting in rover template use #1395

dbanty opened this issue Nov 2, 2022 · 0 comments
Labels
good first issue

Comments

@dbanty
Copy link
Contributor

dbanty commented Nov 2, 2022 •
edited
Loading

we'll want to make sure the terminal is a tty before prompting on it so we don't hang in places like CI - if it's not a TTY we should error early and instruct them to pass required arguments instead (there are examples of this in rover dev code).

Originally posted by @EverlastingBugstopper in #1388 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EverlastingBugstopper @dbanty