diff --git a/.github/workflows/run-smokes-scheduled.yml b/.github/workflows/run-smokes-scheduled.yml index bade5f93b..61c1a2762 100644 --- a/.github/workflows/run-smokes-scheduled.yml +++ b/.github/workflows/run-smokes-scheduled.yml @@ -2,7 +2,7 @@ on: schedule: - cron: '0 9 * * *' -name: "Run Smokes (Automated)" +name: "Run Smoke Tests (Automated)" jobs: calculate_correct_version_ranges: name: "Calculate Correct Version Ranges" @@ -44,7 +44,7 @@ jobs: runs-on: ubuntu-24.04 needs: run-smokes name: "Message Slack On Test Failure" - if: ${{ needs.run-smokes.result == 'failure' }} + if: ${{ failure() }} steps: - name: Send custom JSON data to Slack workflow id: slack diff --git a/tests/e2e/graph/introspect.rs b/tests/e2e/graph/introspect.rs index ff954ace8..5cba69b0f 100644 --- a/tests/e2e/graph/introspect.rs +++ b/tests/e2e/graph/introspect.rs @@ -109,7 +109,8 @@ async fn e2e_test_rover_graph_introspect_watch( schema_file .write(new_schema.as_bytes()) .expect("Could not update schema"); - tokio::time::sleep(Duration::from_secs(2)).await; + tokio::time::sleep(Duration::from_secs(5)).await; + child.kill().unwrap(); // Get the new result out_file .seek(SeekFrom::Start(0)) @@ -131,6 +132,4 @@ async fn e2e_test_rover_graph_introspect_watch( asserting(&format!("changes which was {:?}, has no elements", changes)) .that(&changes) .is_empty(); - - child.kill().unwrap(); } diff --git a/tests/e2e/subgraph/introspect.rs b/tests/e2e/subgraph/introspect.rs index 601f5e6f4..83d69bb6e 100644 --- a/tests/e2e/subgraph/introspect.rs +++ b/tests/e2e/subgraph/introspect.rs @@ -110,7 +110,8 @@ async fn e2e_test_rover_subgraph_introspect_watch( schema_file .write(new_schema.as_bytes()) .expect("Could not update schema"); - tokio::time::sleep(Duration::from_secs(2)).await; + tokio::time::sleep(Duration::from_secs(5)).await; + child.kill().unwrap(); // Get the new result out_file .seek(SeekFrom::Start(0)) @@ -132,6 +133,4 @@ async fn e2e_test_rover_subgraph_introspect_watch( asserting(&format!("changes which was {:?}, has no elements", changes)) .that(&changes) .is_empty(); - - child.kill().unwrap(); }