Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query plan cache key follow up #5160

Closed
Geal opened this issue May 14, 2024 · 0 comments · Fixed by #6206 · May be fixed by #5255
Closed

Query plan cache key follow up #5160

Geal opened this issue May 14, 2024 · 0 comments · Fixed by #6206 · May be fixed by #5255
Assignees

Comments

@Geal
Copy link
Contributor

Geal commented May 14, 2024

as a follow up to #5100, there are more fixes to apply to query plan cache keys:

@Geal Geal self-assigned this May 16, 2024
@Geal Geal closed this as completed in #6206 Nov 5, 2024
@Geal Geal closed this as completed in 36bdb5e Nov 5, 2024
LongLiveCHIEF pushed a commit to StateFarmIns/router that referenced this issue Nov 21, 2024
Fix apollographql#5160

This splits part of the work from apollographql#5255 to make it easier to merge.
This covers improvements and fixes to the query planner cache key from changes related to the query hashing algorithm and query plan reuse during warmup.

Fixed:
* use prefixes for each part of the redis cache key so they become self describing
* remove the custom Hash implementation for the cache key
* remove JSON serialization
* hash the Rust planner's config only once, not on every cache query

Co-authored-by: Ivan Goncharov <[email protected]>
Co-authored-by: Jeremy Lempereur <[email protected]>
Co-authored-by: Gary Pennington <[email protected]>
Co-authored-by: Jesse Rosenberger <[email protected]>
Co-authored-by: Renée <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant