Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logs on subgrequest http error #2918

Open
Meemaw opened this issue Apr 7, 2023 · 1 comment · May be fixed by #2919
Open

Improve logs on subgrequest http error #2918

Meemaw opened this issue Apr 7, 2023 · 1 comment · May be fixed by #2919

Comments

@Meemaw
Copy link
Contributor

Meemaw commented Apr 7, 2023

Describe the solution you'd like
Whenever there are "subgraph" issues, its almost impossible to figure what's going on from the apollo router's logs. You might see something generic like this:

Screenshot 2023-04-07 at 08 48 52

This is missing 2 crucial pieces of information:

  • what was the http status code of the response
  • what was the text body of the response (if any)

There could be extra components between the router and subgraph (e.g service mesh), so having this additional information would demistify where things went wrong.

Describe alternatives you've considered
N/A

Additional context
N/A

@Meemaw
Copy link
Contributor Author

Meemaw commented Apr 7, 2023

It seems this was partially addressed in #2902.

Is it possible to add it to SubrequestMalformedResponse as well: https://github.com/apollographql/router/blob/dev/apollo-router/src/services/subgraph_service.rs#L417?

@dragonbear-os dragonbear-os linked a pull request Apr 7, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants