Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer & Stream now that they are part of graphql.js #4769

Closed
AndreasHald opened this issue Nov 30, 2020 · 4 comments
Closed

Defer & Stream now that they are part of graphql.js #4769

AndreasHald opened this issue Nov 30, 2020 · 4 comments

Comments

@AndreasHald
Copy link

Hi, now that Defer & Stream are becomming a part og graphql.js (graphql/graphql-js#2319 still an experimental branch) what's the process for integrating it into apollo server / client?

@johnculviner
Copy link

Looking forward to this one! I'm seeing it on GQL libs for Java, Scala and Ruby now too.

This solves one of my biggest gripes with GQL - your response performance is limited to the performance characteristics of the slowest resolver dependency unless you issue multiple queries which really limits the ability of GQL to serve as a near perfect abstraction over legacy APIs etc.

@acao
Copy link

acao commented Feb 7, 2021

we now have a reference server implementation for the first transport spec for @defer and @stream IncrementalDelivery

it will involve handling partial responses, which is not going to be easy with the way apollo-server-core is decoupled from output, which worked fine up until now because responses weren't iterative.

the express-grapql PR makes it look easy because of how tightly we're coupled to express

you'd think we could follow a similar pattern to multipart upload, however IncrementalDelivery specifies a request protocol, not a response protocol

your response performance is limited to the performance characteristics of the slowest resolver dependency unless you issue multiple queries which really limits the ability of GQL to serve as a near perfect abstraction over legacy APIs etc.

this, so much! hoping for such wide adoption this year, that graphql developers will be taking this feature for granted in ~2-3 years 😆

@acao
Copy link

acao commented Feb 7, 2021

seems that @abernix has an effort afoot to rearchitect for this feature and others, as well as provide more flexibility! very neat

#3184

@hwillson
Copy link
Member

We're working on @defer / @stream support and will be tracking progress in #5893. Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants