Gt 367 GitHub workflow to merge main into develop #282
Conversation
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: ca7e2e5bad4d2fcee5312ccf |
alocay
changed the title
swcollard
left a comment
swcollard
left a comment
There was a problem hiding this comment.
This all looks reasonable to me! Inputs line up with the create pr action, https://github.com/marketplace/actions/create-pull-request
| pull_request: | ||
| types: [closed] | ||
| branches: [main] |
There was a problem hiding this comment.
A pull request to main happens when we have a release, correct?
Can we make sure that the settings for this package is set up to where you can only merge to main from pull requests? So folks can't push to main directly
There was a problem hiding this comment.
I believe main already has this branch protection rule in place by default but we can double check.
| uses: peter-evans/create-pull-request@v6 | ||
| with: | ||
| branch: ${{ steps.meta.outputs.branch }} | ||
| base: ${{ env.BASE_BRANCH }} |
There was a problem hiding this comment.
I'm a little confused why in this case it uses env.BASE_BRANCH when above it just references it as BASE_BRANCH?
I am guessing it's because above that is in a bash script and not just yml templating so the syntax is different.
There was a problem hiding this comment.
So the run portion above runs as a bash script so we just reference it as ${BASE_BRANCH} but this portion doesn't run as a bash script and instead needs it as a GitHub action expression. Hence the two different formats.
* ci: adding a workflow to autogen main to develop sync pr * ci: adding a work dispatch trigger for testing * chore: adjusting bool check for consistency
Adding a github workflow to auto-generate a sync PR to merge main into develop.