address comments

Author: nicholascioli

crates/apollo-mcp-server/src/operations/operation.rs

@@ -543,7 +543,7 @@ fn get_json_schema(
                         .map(|d| d.join("#"))
                 });
 
-            let nested = schema_walker::walk(
+            let nested = schema_walker::type_to_schema(
                 variable.ty.as_ref(),
                 graphql_schema,
                 &mut definitions,
@@ -656,7 +656,7 @@ mod tests {
         .expect("schema should be valid")
     });
 
-    /// JSON-ifies the input, sorting the object keys
+    /// Serializes the input to JSON, sorting the object keys
     macro_rules! to_sorted_json {
         ($json:expr) => {{
             let mut j = serde_json::json!($json);

crates/apollo-mcp-server/src/operations/schema_walker.rs

@@ -9,11 +9,14 @@ use serde_json::{Map, Value};
 
 use crate::custom_scalar_map::CustomScalarMap;
 
-pub(super) mod name;
-pub(super) mod r#type;
+mod name;
+mod r#type;
 
-/// Walk a top-level type and generate a JSON Schema
-pub fn walk(
+/// Convert a GraphQL type into a JSON Schema.
+///
+/// Note: This is recursive, which might cause a stack overflow if the type is
+/// sufficiently nested / complex.
+pub fn type_to_schema(
     r#type: &Type,
     schema: &GraphQLSchema,
     definitions: &mut Map<String, Value>,