🧪 @experimental support #4091
🧪 @experimental support #4091
Conversation
✅ Deploy Preview for apollo-android-docs canceled.
|
apollo-compiler/src/main/kotlin/com/apollographql/apollo3/compiler/ir/IrBuilder.kt
Show resolved
Hide resolved
kotlin-js-store/yarn.lock
Outdated
| dependencies: | ||
| mime-types "~2.1.34" | ||
| negotiator "0.6.3" | ||
|
|
There was a problem hiding this comment.
No idea why this was added.
There was a problem hiding this comment.
And it was just removed 🤔 .... My current guess is that it depends if it's the root project or the tests project that is run last.... But that'd be a bit scary TBH
There was a problem hiding this comment.
My current guess is that it depends if it's the root project or the tests project that is run last
confirmed. I'll make a follow up PR
...piler/src/main/kotlin/com/apollographql/apollo3/compiler/codegen/kotlin/helpers/NamedType.kt
Show resolved
Hide resolved
apollo-compiler/src/main/kotlin/com/apollographql/apollo3/compiler/ir/IrBuilder.kt
Show resolved
Hide resolved
| * - AnnotationTarget.PROPERTY | ||
| * - AnnotationTarget.CLASS | ||
| * | ||
| * Default: "com.apollographql.apollo3.annotations.ApolloExperimental" |
There was a problem hiding this comment.
I'm not 100% convinced we should re-use ApolloExperimental for the default as it is currently kind of specific to the project's codebase, so maybe it would be worth it to introduce a specific Experimental annotation.
Not a big deal for the time being!
There was a problem hiding this comment.
Agreed the semantics are different but didn't find a good alternative name. GraphQLExperimental maybe ?
There was a problem hiding this comment.
I was thinking just Experimental but I like GraphQLExperimental too. Another idea: SchemaExperimental.
There was a problem hiding this comment.
I was a bit concerned Experimental would clash with other annotation but maybe it's not the case. Maybe we should make @Experimental @ApolloExperimental 🙃 .
Just kidding. I'll go with @Experimental and we'll see how that unfolds.
Add support for the
@experimentaldirective. By default, it annotates experimental fields, input fields and enum values withcom.apollographql.apollo3.annotations.Experimental. This can be changed with a Gradle setting:apollo { experimentalAnnotation.set("com.example.MyOptInAnnotation") // "none" is a special value that will not emit any annotation experimentalAnnotation.set("none") }