Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to allow @client directives to make it to the link chain #10303

Closed
jerelmiller opened this issue Nov 21, 2022 · 1 comment · Fixed by #10346
Closed

Add option to allow @client directives to make it to the link chain #10303

jerelmiller opened this issue Nov 21, 2022 · 1 comment · Fixed by #10346
Assignees
Milestone

Comments

@jerelmiller
Copy link
Member

jerelmiller commented Nov 21, 2022

This ticket is broken out of #10060 to track the work for points 1 and 2 in that issue:

  1. Sending queries into the link chain with @client directives with an option to enable / disable by default.
  2. Stripping those @client fields in HttpLink and other terminating links, if not handled earlier.

We can introduce this change in a non-breaking way by adding a new option that will allow the @client directives to make it to the link chain. The default value of this new option should maintain existing behavior which strips out @client before it makes it to the link chain. This will allow use cases where a developer might want to do some manipulation of the query with @client before it makes it to the terminating link.

Bonus: We might consider allowing individual queries to opt in/out of this behavior as well like we do with other options.

We'll need to update Documentation to explain this functionality as well.

@jerelmiller
Copy link
Member Author

Finished with #10346

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants