change check to globals.__DEV__ !== false

Author: phryneas

config/jest.config.js

@@ -3,6 +3,9 @@ const defaults = {
   preset: "ts-jest",
   testEnvironment: "jsdom",
   setupFilesAfterEnv: ["<rootDir>/config/jest/setup.ts"],
+  globals: {
+    __DEV__: undefined,
+  },
   testEnvironmentOptions: {
     url: "http://localhost",
   },

config/postprocessDist.ts

@@ -25,28 +25,6 @@ eachFile(distDir, (file, relPath) => new Promise((resolve, reject) => {
     const tr = new Transformer;
     const output = tr.transform(source, file);
 
-    if (
-      /\b__DEV__\b/.test(source) &&
-      // Ignore modules that reside within @apollo/client/utilities/globals.
-      relPath.split(path.sep, 2).join("/") !== "utilities/globals"
-    ) {
-      let importsUtilitiesGlobals = false;
-
-      tr.absolutePaths.forEach(absPath => {
-        const distRelativePath =
-          path.relative(distDir, absPath).split(path.sep).join("/");
-        if (distRelativePath === "utilities/globals/index.js") {
-          importsUtilitiesGlobals = true;
-        }
-      });
-
-      if (!importsUtilitiesGlobals) {
-        reject(new Error(`Module ${
-          relPath
-        } uses __DEV__ but does not import @apollo/client/utilities/globals`));
-      }
-    }
-
     if (source === output) {
       resolve(file);
     } else {

config/processInvariants.ts

@@ -190,20 +190,25 @@ function transform(code: string, relativeFilePath: string) {
     },
   });
 
-  recast.visit(ast, {
-    visitIdentifier(path) {
-      this.traverse(path);
-      const node = path.node;
-      if (isDEVExpr(node)) {
-        return b.memberExpression(
-          b.identifier('globalThis'),
-          b.identifier('__DEV__')
-        );
-      }
+  if (relativeFilePath !== 'config/jest/setup.js')
+    recast.visit(ast, {
+      visitIdentifier(path) {
+        this.traverse(path);
+        const node = path.node;
+        if (isDEVExpr(node)) {
+          return b.binaryExpression(
+            '!==', 
+            b.memberExpression(
+              b.identifier('globalThis'),
+              b.identifier('__DEV__')
+            ),
+            b.literal(false)
+          );
+        }
 
-      return node;
-    },
-  });
+        return node;
+      },
+    });
 
   return reprint(ast);
 }

src/utilities/globals/DEV.ts

@@ -1,13 +1,6 @@
 import { invariant, newInvariantError, InvariantError } from "./invariantWrappers";
 
-// Just in case the graphql package switches from process.env.NODE_ENV to
-// __DEV__, make sure __DEV__ is polyfilled before importing graphql.
-import DEV from "./DEV";
-export { DEV }
-export function checkDEV() {
-  invariant("boolean" === typeof DEV, "%s", DEV);
-}
-
+export function checkDEV(){}
 // Import graphql/jsutils/instanceOf safely, working around its unchecked usage
 // of process.env.NODE_ENV and https://github.com/graphql/graphql-js/pull/2894.
 import { removeTemporaryGlobals } from "./fix-graphql";
@@ -20,6 +13,5 @@ export { maybe } from "./maybe";
 export { default as global } from "./global";
 export { invariant, newInvariantError, InvariantError }
 
-// Ensure __DEV__ was properly initialized, and prevent tree-shaking bundlers
-// from mistakenly pruning the ./DEV module (see issue #8674).
-checkDEV();
+// @ts-ignore
+export const DEV = __DEV__;