remove query option from hooks with two args (#10527)

* remove `query` option from hooks with two args
Removes the `query`/`mutation`/`subscription` option
from hooks that already take that value as their first argument.
These options have not been wired up, but were present in the TS types.

* bump bundle size

---------

Co-authored-by: Alessia Bellisario <[email protected]>

Author: phryneas

.changeset/heavy-ties-sneeze.md

@@ -0,0 +1,5 @@
+---
+'@apollo/client': minor
+---
+
+Remove the `query`/`mutation`/`subscription` option from hooks that already take that value as their first argument.

src/react/hooks/useLazyQuery.ts

@@ -5,6 +5,7 @@ import { useCallback, useEffect, useMemo, useRef } from 'react';
 import { OperationVariables } from '../../core';
 import { mergeOptions } from '../../utilities';
 import {
+  LazyQueryHookExecOptions,
   LazyQueryHookOptions,
   LazyQueryResultTuple,
   NoInfer,
@@ -30,12 +31,12 @@ export function useLazyQuery<TData = any, TVariables extends OperationVariables
 ): LazyQueryResultTuple<TData, TVariables> {
   const abortControllersRef = useRef(new Set<AbortController>());
 
-  const execOptionsRef = useRef<Partial<LazyQueryHookOptions<TData, TVariables>>>();
+  const execOptionsRef = useRef<Partial<LazyQueryHookExecOptions<TData, TVariables>>>();
   const merged = execOptionsRef.current ? mergeOptions(options, execOptionsRef.current) : options;
 
   const internalState = useInternalState<TData, TVariables>(
     useApolloClient(options && options.client),
-    merged?.query ?? query
+    execOptionsRef.current?.query ?? query
   );
 
   const useQueryResult = internalState.useQuery({

src/react/types/types.ts

@@ -85,13 +85,20 @@ export interface QueryDataOptions<TData = any, TVariables extends OperationVaria
 
 export interface QueryHookOptions<TData = any, TVariables extends OperationVariables = OperationVariables>
   extends QueryFunctionOptions<TData, TVariables> {
-  query?: DocumentNode | TypedDocumentNode<TData, TVariables>;
 }
 
 export interface LazyQueryHookOptions<
   TData = any,
   TVariables extends OperationVariables = OperationVariables
-> extends Omit<QueryHookOptions<TData, TVariables>, 'skip'> {}
+> extends Omit<QueryHookOptions<TData, TVariables>, 'skip'> {
+}
+
+export interface LazyQueryHookExecOptions<
+  TData = any,
+  TVariables extends OperationVariables = OperationVariables
+> extends LazyQueryHookOptions<TData, TVariables> {
+  query?: DocumentNode | TypedDocumentNode<TData, TVariables>;
+}
 
 /**
  * suspensePolicy determines how suspense behaves for a refetch. The options are:
@@ -153,7 +160,7 @@ export type QueryTuple<TData, TVariables extends OperationVariables> =
   LazyQueryResultTuple<TData, TVariables>;
 
 export type LazyQueryExecFunction<TData, TVariables extends OperationVariables> = (
-  options?: Partial<LazyQueryHookOptions<TData, TVariables>>,
+  options?: Partial<LazyQueryHookExecOptions<TData, TVariables>>,
 ) => Promise<QueryResult<TData, TVariables>>;
 
 export type LazyQueryResultTuple<TData, TVariables extends OperationVariables> = [
@@ -216,7 +223,6 @@ export interface MutationHookOptions<
   TContext = DefaultContext,
   TCache extends ApolloCache<any> = ApolloCache<any>,
 > extends BaseMutationOptions<TData, TVariables, TContext, TCache> {
-  mutation?: DocumentNode | TypedDocumentNode<TData, TVariables>;
 }
 
 export interface MutationDataOptions<
@@ -292,7 +298,6 @@ export interface SubscriptionHookOptions<
   TData = any,
   TVariables extends OperationVariables = OperationVariables
 > extends BaseSubscriptionOptions<TData, TVariables> {
-  subscription?: DocumentNode | TypedDocumentNode<TData, TVariables>;
 }
 
 export interface SubscriptionDataOptions<