-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add usage instructions for multiple appid in the Apollo client #5295
Add usage instructions for multiple appid in the Apollo client #5295
Conversation
WalkthroughThe pull request includes substantial updates to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
add multiple appid dosc
9932bc4
to
fedb5ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
docs/zh/client/java-sdk-user-guide.md (1)
733-742
: Consider adding more details about key collision handling.While the implementation is correct, it would be helpful to expand the comment about key precedence when using multiple AppIDs to include:
- Examples of key collision scenarios
- How the priority is determined when the same key exists in multiple AppIDs
docs/en/client/java-sdk-user-guide.md (1)
763-774
: Consider enhancing the documentation around key precedence.While the implementation is correct, the comment about key precedence could be expanded to include:
- Specific examples showing key collision scenarios
- A detailed explanation of how priority is determined when identical keys exist across multiple AppIDs
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/en/client/java-sdk-user-guide.md
(2 hunks)docs/zh/client/java-sdk-user-guide.md
(2 hunks)
🔇 Additional comments (2)
docs/zh/client/java-sdk-user-guide.md (1)
586-595
: LGTM! Clear documentation for the new multi-AppID API feature.
The code example clearly demonstrates how to retrieve configurations from different AppIDs and their namespaces.
docs/en/client/java-sdk-user-guide.md (1)
614-623
: LGTM! Clear documentation for the new multi-AppID API feature.
The code example effectively demonstrates the usage of the new multi-AppID configuration retrieval functionality.
What's the purpose of this PR
Add usage instructions for multiple appid in the Apollo client
Which issue(s) this PR fixes:
Fixes #
Brief changelog
update docs for java client
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.Summary by CodeRabbit
New Features
AppId
andApollo Meta Server
.Bug Fixes
Documentation