Skip to content

Commit 21259e5

Browse files
Aniloplenobodyiam
authored andcommitted
feat(openapi): create app (#32)
* feat(openapi): create app * feat(openapi): create app * fix: remove create app by env * feat: support init admins when create app * refactor: path "apps/create" -> "apps" * test: move to IntegrationTest * Update AppOpenApiServiceTest.java * refactor: use OpenCreateAppDTO instead of OpenAppDTO * test: testCreateAppThenCreateNamespaceThenRelease * Update CHANGES.md * add assignAppRoleToSelf to mark role permission * testCreateAppButHaveNoAppRole * refactor: use composite instead of extend OpenAppDTO * Update OpenCreateAppDTO.java * test: make test more complex. create the cluster too
1 parent 5344bc4 commit 21259e5

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

apollo-openapi/src/main/java/com/ctrip/framework/apollo/openapi/client/url/OpenApiPathBuilder.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import java.util.Arrays;
2828
import java.util.Base64;
2929
import java.util.HashMap;
30+
import java.util.LinkedHashMap;
3031
import java.util.List;
3132
import java.util.Map;
3233

@@ -60,7 +61,7 @@ public static OpenApiPathBuilder newBuilder() {
6061

6162
private OpenApiPathBuilder() {
6263
this.pathVariable = new HashMap<>();
63-
this.params = new HashMap<>();
64+
this.params = new LinkedHashMap<>();
6465
}
6566

6667
public OpenApiPathBuilder envPathVal(String env) {

apollo-openapi/src/test/java/com/ctrip/framework/apollo/openapi/client/service/ItemOpenApiServiceTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -318,8 +318,8 @@ public void testFindItemsByNamespace() throws Exception {
318318

319319
HttpGet get = request.getValue();
320320

321-
assertEquals(String.format("%s/envs/%s/apps/%s/clusters/%s/namespaces/%s/items?size=%s&page=%s",
322-
someBaseUrl, someEnv, someAppId, someCluster, someNamespace, size, page), get.getURI().toString());
321+
assertEquals(String.format("%s/envs/%s/apps/%s/clusters/%s/namespaces/%s/items?page=%s&size=%s",
322+
someBaseUrl, someEnv, someAppId, someCluster, someNamespace, page, size), get.getURI().toString());
323323
}
324324

325325
@Test(expected = RuntimeException.class)

0 commit comments

Comments
 (0)