Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aircraft endpoint CircleCI test errors #481

Closed
valentinoli opened this issue Feb 4, 2019 · 2 comments
Closed

Aircraft endpoint CircleCI test errors #481

valentinoli opened this issue Feb 4, 2019 · 2 comments

Comments

@valentinoli
Copy link

valentinoli commented Feb 4, 2019

Hey all. I've been trying to get this pull request to pass the integration tests without any luck... Keep getting the following errors even though the endpoint works perfectly locally. Any ideas what might be causing the refusal of samgongustofa.is to respond? Both errors are due to this.

  1) aircraft
       correct-fields
         should return an array of objects containing correct fields:
     Uncaught AssertionError: Does not contain a 'results' field
      at assertResults (lib/test_helpers.js:7:3)
      at Request._callback (lib/test_helpers.js:59:5)
      at Request.self.callback (node_modules/request/request.js:186:22)
      at Request.<anonymous> (node_modules/request/request.js:1163:10)
      at IncomingMessage.<anonymous> (node_modules/request/request.js:1085:12)
      at endReadableNT (_stream_readable.js:975:12)
      at _combinedTickCallback (internal/process/next_tick.js:80:11)
      at process._tickDomainCallback (internal/process/next_tick.js:128:9)

  2) aircraft
       aircraft-not-found
         should return a 404 when an aircraft is not found:

      Uncaught AssertionError: 'www.samgongustofa.is refuses to respond or give back data' === 'No aircraft found with the query loftur'
      + expected - actual

      -www.samgongustofa.is refuses to respond or give back data
      +No aircraft found with the query loftur
@valentinoli valentinoli changed the title Aircraft endpoint CI errors Aircraft endpoint CircleCI test errors Feb 4, 2019
@MiniGod
Copy link
Member

MiniGod commented Feb 5, 2019

Please keep conversation in the pull request #480.

@MiniGod MiniGod closed this as completed Feb 5, 2019
@valentinoli
Copy link
Author

Will do next time 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants