Skip to content

Conversation

@asadali214
Copy link
Collaborator

What

This PR fixes a bug where VoidType was being returned instead of ApiResponse. It handles it via return type creator.

Why

To improve coverage of void return type cases

Closes #76

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

N/A

Breaking change

N/A

Testing

Unit tests are added to test these changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

@sonarqubecloud
Copy link

@asadali214 asadali214 merged commit 846807f into main Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ApiCall with void return type should also be converted via returnTypeCreator

3 participants