feat(enums): relaxing enum validation at deserialization #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.




Why
In order to be able to relax enum validation during deserialization, we had two options:
Since
nullableproperties already have a set meaning, it wouldn't make sense to cause confusion by givingnullyet another purpose. The second option allows us to be more explicit about what we mean when we allow any unknown values during deserialization.Therefore, the second option has been implemented.
What
JsonConverterto gracefully handle cases where we get unexpected enum values in the responseJsonConverterCloses #65
Type of change
Select multiple if applicable.
Dependency Change
N/A
Breaking change
N/A
Testing
List the steps that were taken to test the changes
Checklist