Skip to content

Conversation

@asadali214
Copy link
Collaborator

@asadali214 asadali214 commented Oct 24, 2023

What

This PR fixes a bug for multipleAuth's combination Auth1 OR Auth2 where both authentications Auth1 and Auth2 are being applied. Instead, we need to apply either Auth1 or Auth2 to the request for such cases.

Why

We needed to fix the OR auth applying functionality

Closes #56

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

@asadali214 asadali214 self-assigned this Oct 24, 2023
@asadali214 asadali214 changed the title 56 fix multipleauth or group applying functionality fix(or-multiple-auth): applying only the first available auth for OR cases Oct 24, 2023
Copy link
Contributor

@sufyankhanrao sufyankhanrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asadali214 asadali214 merged commit 7fb7681 into main Oct 24, 2023
@asadali214 asadali214 deleted the 56-fix-multipleauth-or-group-applying-functionality branch July 4, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix MultipleAuth's OR group applying functionality

3 participants