Skip to content

feat(support-union-type): add the support for union types #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Jul 31, 2023
Merged

feat(support-union-type): add the support for union types #48

merged 47 commits into from
Jul 31, 2023

Conversation

@hamzashoukat94
Copy link
Contributor

@hamzashoukat94 hamzashoukat94 commented Jul 11, 2023

What

In this pull request, I added the support for the union type (OneOf/AnyOf).

Why

  • To support the union-type object.

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

@hamzashoukat94 hamzashoukat94 self-assigned this Jul 11, 2023
@hamzashoukat94 hamzashoukat94 linked an issue Jul 11, 2023 that may be closed by this pull request
Add support for oneOf and anyOf union types #47
Closed
@asadali214 asadali214 closed this Jul 13, 2023
asadali214 and others added 21 commits July 21, 2023 16:40
@asadali214
Merge branch '47-add-support-for--union-types' of https://github.com/…
65430e4 
…apimatic/core-lib-csharp into 47-add-support-for--union-types
@hamzashoukat94
issues fixed
02c75ad
@hamzashoukat94
Container tests
e1bf40e
@asadali214
fixed native dictionary mapping case for union types
7494ab8
@hamzashoukat94
Changed namespaces
cea8bdc
@hamzashoukat94
remove unused imports
358f4ea
@hamzashoukat94
UnionTypeConverter fixes
15ef0bd
@hamzashoukat94
Pick up the spaced token from Json
d7a82f5
@hamzashoukat94
Update EnumCaseConverter
b7a650b
@asadali214
Added IsProperSubsetOf method in TestHelper along with refactoring an…
e13fa7a 
…d unit tests to 100% new code coverage
@asadali214
Merge branch '47-add-support-for--union-types' of https://github.com/…
a2b0473 
…apimatic/core-lib-csharp into 47-add-support-for--union-types
@asadali214
fixed null header value test
cc491c6
@hamzashoukat94
Handled Enum and Datetime
3fe312b
@asadali214
bumped code coverage to 100% by adding new unit tests to cover newly …
2f4ed7d 
…added converters
@asadali214
fixed rafactoring issues suggested by code climate
2878f9d
@asadali214
change access modifier for 2 TestHelper methods
43581a4
@hamzashoukat94
Code cleanup
723f3b0
@asadali214
Updated design of NativeAnyOfContainer to replace ICases implementati…
9a8b555 
…on with Function arguments. Changes have been made in unit tests too
@hamzashoukat94
Handle header and template dateTime cases
e88748c
@hamzashoukat94
Incorporate the container's Match method changes in unit tests
401cbe2
@asadali214
removed early return for strings from CoreHelper's JsonSerialize
e9237a0
@asadali214 asadali214 self-assigned this Jul 31, 2023
asadali214
asadali214 approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@asadali214 asadali214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes looks good to me

@hamzashoukat94 hamzashoukat94 merged commit 08a0769 into main Jul 31, 2023
@asadali214 asadali214 deleted the 47-add-support-for--union-types branch July 31, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asadali214 asadali214 asadali214 approved these changes

Assignees

@asadali214 asadali214

@hamzashoukat94 hamzashoukat94

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for oneOf and anyOf union types

3 participants

@hamzashoukat94 @asadali214