Skip to content

Conversation

@hamzashoukat94
Copy link
Contributor

Added the support for map of complex type

closes #22

@hamzashoukat94 hamzashoukat94 self-assigned this Jan 4, 2023
@hamzashoukat94 hamzashoukat94 changed the title feat(map-of-complextypes): add the support for map of complex type feat(map-of-complextypes): add the support for map of complex type in query parameters Jan 9, 2023
Copy link
Collaborator

@asadali214 asadali214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identified a few code smells in the newly added code

Copy link
Collaborator

@asadali214 asadali214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@hamzashoukat94 hamzashoukat94 merged commit c4bb5cb into main Jan 10, 2023
@asadali214 asadali214 deleted the 22-feature-support-map-of-complextype branch January 10, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the support for Map of Complex Type in the core library

3 participants