Skip to content

refactor(decrease-complexity): refactor to decrease complexity #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2023
Merged

refactor(decrease-complexity): refactor to decrease complexity #21

merged 2 commits into from
Jan 4, 2023

Conversation

@hamzashoukat94
Copy link
Contributor

@hamzashoukat94 hamzashoukat94 commented Jan 4, 2023

Refactored CoreHelper and TestHelper to decrease cognitive complexity.

@hamzashoukat94 hamzashoukat94 self-assigned this Jan 4, 2023
asadali214
asadali214 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@asadali214 asadali214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@hamzashoukat94 hamzashoukat94 merged commit 020b24f into main Jan 4, 2023
@hamzashoukat94 hamzashoukat94 mentioned this pull request Jan 4, 2023
Closed
@asadali214 asadali214 deleted the 20-refactor-lib-decrease-complexity branch January 4, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asadali214 asadali214 asadali214 approved these changes

Assignees

@hamzashoukat94 hamzashoukat94

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hamzashoukat94 @asadali214