fix(serialization): stack overflow in JsonStringConverter (#61)

Author: mrafnadeem-apimatic

APIMatic.Core.Test/Utilities/CoreHelperTest.cs

@@ -7,6 +7,7 @@
 using APIMatic.Core.Test.MockTypes.Models;
 using APIMatic.Core.Test.MockTypes.Utilities;
 using APIMatic.Core.Utilities;
+using APIMatic.Core.Utilities.Converters;
 using APIMatic.Core.Utilities.Date;
 using Newtonsoft.Json.Linq;
 using NUnit.Framework;
@@ -107,6 +108,24 @@ public void JsonSerialize_DateTime_RFCFormat()
             Assert.AreEqual(expected, actual);
         }
 
+        [Test]
+        public void JsonSerialize_JsonString()
+        {
+            string str = "a";
+            string expected = "\"a\"";
+            var actual = CoreHelper.JsonSerialize(str, new JsonStringConverter());
+            Assert.That(actual, Is.EquivalentTo(expected));
+        }
+
+        [Test]
+        public void JsonSerialize_JsonString_NotAString()
+        {
+            int number = 24;
+            string expected = "24";
+            var actual = CoreHelper.JsonSerialize(number, new JsonStringConverter());
+            Assert.That(actual, Is.EquivalentTo(expected));
+        }
+
         #endregion
 
         #region Deserialize

APIMatic.Core/Utilities/Converters/JsonStringConverter.cs

@@ -1,5 +1,6 @@
 using System;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Linq;
 
 namespace APIMatic.Core.Utilities.Converters
 {
@@ -32,8 +33,17 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist
             return null;
         }
 
-        public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer) =>
-            serializer.Serialize(writer, value);
+        public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
+        {
+            JToken token = JToken.FromObject(value);
+
+            if (token.Type == JTokenType.String)
+            {
+                JValue val = (JValue)token;
+
+                val.WriteTo(writer);
+            }
+        }
     }
 
 }