diff --git a/zeppelin-server/src/test/java/org/apache/zeppelin/rest/AbstractTestRestApi.java b/zeppelin-server/src/test/java/org/apache/zeppelin/rest/AbstractTestRestApi.java index 5ea3c0943a5..613a2d07de0 100644 --- a/zeppelin-server/src/test/java/org/apache/zeppelin/rest/AbstractTestRestApi.java +++ b/zeppelin-server/src/test/java/org/apache/zeppelin/rest/AbstractTestRestApi.java @@ -378,7 +378,7 @@ protected String createTempSetting(String tempName) .add(tempName, "newGroup", new LinkedList(), - new InterpreterOption(false), + new InterpreterOption(), new Properties()); return setting.id(); } diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java index bad18c02347..2be2a300759 100644 --- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java +++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java @@ -88,7 +88,7 @@ public InterpreterFactory(ZeppelinConfiguration conf, RemoteInterpreterProcessListener remoteInterpreterProcessListener, DependencyResolver depResolver) throws InterpreterException, IOException, RepositoryException { - this(conf, new InterpreterOption(true), angularObjectRegistryListener, + this(conf, new InterpreterOption(), angularObjectRegistryListener, remoteInterpreterProcessListener, depResolver); } @@ -312,7 +312,6 @@ private void loadFromFile() throws IOException { // While we decided to turn this feature on always (without providing // enable/disable option on GUI). // previously created setting should turn this feature on here. - setting.getOption().setRemote(true); InterpreterSetting intpSetting = new InterpreterSetting( setting.id(), @@ -499,19 +498,11 @@ public InterpreterGroup createInterpreterGroup(String id, InterpreterOption opti AngularObjectRegistry angularObjectRegistry; InterpreterGroup interpreterGroup = new InterpreterGroup(id); - if (option.isRemote()) { - angularObjectRegistry = new RemoteAngularObjectRegistry( - id, - angularObjectRegistryListener, - interpreterGroup - ); - } else { - angularObjectRegistry = new AngularObjectRegistry( - id, - angularObjectRegistryListener); - - // TODO(moon) : create distributed resource pool for local interpreters and set - } + angularObjectRegistry = new RemoteAngularObjectRegistry( + id, + angularObjectRegistryListener, + interpreterGroup + ); interpreterGroup.setAngularObjectRegistry(angularObjectRegistry); return interpreterGroup; @@ -581,17 +572,11 @@ public void createInterpretersForNote( && info.getGroup().equals(groupName)) { Interpreter intp; - if (option.isRemote()) { - intp = createRemoteRepl(info.getPath(), - key, - info.getClassName(), - properties, - interpreterSetting.id()); - } else { - intp = createRepl(info.getPath(), - info.getClassName(), - properties); - } + intp = createRemoteRepl(info.getPath(), + key, + info.getClassName(), + properties, + interpreterSetting.id()); synchronized (interpreterGroup) { List interpreters = interpreterGroup.get(key); diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterOption.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterOption.java index f9e43abfcae..7bf9a4b19e1 100644 --- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterOption.java +++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterOption.java @@ -21,7 +21,7 @@ * */ public class InterpreterOption { - boolean remote; + boolean remote = true; boolean perNoteSession; boolean perNoteProcess; @@ -58,18 +58,12 @@ public void setHost(String host) { } - public InterpreterOption() { - remote = false; - } - - public InterpreterOption(boolean remote) { - this.remote = remote; - } - + @Deprecated public boolean isRemote() { return remote; } + @Deprecated public void setRemote(boolean remote) { this.remote = remote; } diff --git a/zeppelin-zengine/src/test/java/org/apache/zeppelin/interpreter/InterpreterFactoryTest.java b/zeppelin-zengine/src/test/java/org/apache/zeppelin/interpreter/InterpreterFactoryTest.java index 3d9ee6ff5cb..9c6ec072697 100644 --- a/zeppelin-zengine/src/test/java/org/apache/zeppelin/interpreter/InterpreterFactoryTest.java +++ b/zeppelin-zengine/src/test/java/org/apache/zeppelin/interpreter/InterpreterFactoryTest.java @@ -57,7 +57,7 @@ public void setUp() throws Exception { System.setProperty(ConfVars.ZEPPELIN_INTERPRETERS.getVarName(), "org.apache.zeppelin.interpreter.mock.MockInterpreter1,org.apache.zeppelin.interpreter.mock.MockInterpreter2"); conf = new ZeppelinConfiguration(); depResolver = new DependencyResolver(tmpDir.getAbsolutePath() + "/local-repo"); - factory = new InterpreterFactory(conf, new InterpreterOption(false), null, null, depResolver); + factory = new InterpreterFactory(conf, new InterpreterOption(), null, null, depResolver); context = new InterpreterContext("note", "id", "title", "text", null, null, null, null, null, null, null); } @@ -115,7 +115,7 @@ public void testExceptions() throws InterpreterException, IOException, Repositor assertEquals("Test null option" , e.getMessage(),new NullArgumentException("option").getMessage()); } try { - factory.add("a mock", "mock2", new LinkedList(), new InterpreterOption(false), null); + factory.add("a mock", "mock2", new LinkedList(), new InterpreterOption(), null); } catch (NullArgumentException e){ assertEquals("Test null properties" , e.getMessage(),new NullArgumentException("properties").getMessage()); } @@ -130,7 +130,7 @@ public void testSaveLoad() throws IOException, RepositoryException { // check if file saved assertTrue(new File(conf.getInterpreterSettingPath()).exists()); - factory.add("newsetting", "mock1", new LinkedList(), new InterpreterOption(false), new Properties()); + factory.add("newsetting", "mock1", new LinkedList(), new InterpreterOption(), new Properties()); assertEquals(3, factory.get().size()); InterpreterFactory factory2 = new InterpreterFactory(conf, null, null, null, depResolver); diff --git a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteInterpreterLoaderTest.java b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteInterpreterLoaderTest.java index f6abc9dc704..777eebf8b28 100644 --- a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteInterpreterLoaderTest.java +++ b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteInterpreterLoaderTest.java @@ -61,7 +61,7 @@ public void setUp() throws Exception { MockInterpreter2.register("mock2", "group2", "org.apache.zeppelin.interpreter.mock.MockInterpreter2"); depResolver = new DependencyResolver(tmpDir.getAbsolutePath() + "/local-repo"); - factory = new InterpreterFactory(conf, new InterpreterOption(false), null, null, depResolver); + factory = new InterpreterFactory(conf, new InterpreterOption(), null, null, depResolver); } @After diff --git a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java index 53749d1ddea..20409f5377e 100644 --- a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java +++ b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java @@ -90,7 +90,7 @@ public void setUp() throws Exception { MockInterpreter2.register("mock2", "org.apache.zeppelin.interpreter.mock.MockInterpreter2"); depResolver = new DependencyResolver(tmpDir.getAbsolutePath() + "/local-repo"); - factory = new InterpreterFactory(conf, new InterpreterOption(false), null, null, depResolver); + factory = new InterpreterFactory(conf, new InterpreterOption(), null, null, depResolver); SearchService search = mock(SearchService.class); notebookRepo = new VFSNotebookRepo(conf); diff --git a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/repo/NotebookRepoSyncTest.java b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/repo/NotebookRepoSyncTest.java index 1699d681bdf..468073a3009 100644 --- a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/repo/NotebookRepoSyncTest.java +++ b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/repo/NotebookRepoSyncTest.java @@ -94,7 +94,7 @@ public void setUp() throws Exception { MockInterpreter2.register("mock2", "org.apache.zeppelin.interpreter.mock.MockInterpreter2"); depResolver = new DependencyResolver(mainZepDir.getAbsolutePath() + "/local-repo"); - factory = new InterpreterFactory(conf, new InterpreterOption(false), null, null, depResolver); + factory = new InterpreterFactory(conf, new InterpreterOption(), null, null, depResolver); search = mock(SearchService.class); notebookRepoSync = new NotebookRepoSync(conf); diff --git a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepoTest.java b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepoTest.java index e5915a97299..fea8d47db76 100644 --- a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepoTest.java +++ b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepoTest.java @@ -76,7 +76,7 @@ public void setUp() throws Exception { this.schedulerFactory = new SchedulerFactory(); depResolver = new DependencyResolver(mainZepDir.getAbsolutePath() + "/local-repo"); - factory = new InterpreterFactory(conf, new InterpreterOption(false), null, null, depResolver); + factory = new InterpreterFactory(conf, new InterpreterOption(), null, null, depResolver); SearchService search = mock(SearchService.class); notebookRepo = new VFSNotebookRepo(conf);