From 61f5d7797e6b9c01febffeb28f8d0b9ecad9821d Mon Sep 17 00:00:00 2001 From: YeonKyung Ryu Date: Sat, 30 Aug 2025 00:38:55 +0900 Subject: [PATCH] [ZEPPELIN-6307] Rename fieldname in NewNoteRequest class --- .../org/apache/zeppelin/rest/NotebookRestApi.java | 4 ++-- .../apache/zeppelin/rest/message/NewNoteRequest.java | 11 +++++------ 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java b/zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java index c0b4a115c7a..192cd5056c5 100644 --- a/zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java +++ b/zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java @@ -508,7 +508,7 @@ public Response createNote(String message) throws IOException { defaultInterpreterGroup = zConf.getString(ZeppelinConfiguration.ConfVars.ZEPPELIN_INTERPRETER_GROUP_DEFAULT); } String noteId = notebookService.createNote( - request.getName(), + request.getNotePath(), defaultInterpreterGroup, request.getAddingEmptyParagraph(), getServiceContext(), @@ -571,7 +571,7 @@ public Response cloneNote(@PathParam("noteId") String noteId, String message) String newNoteName = null; String revisionId = null; if (request != null) { - newNoteName = request.getName(); + newNoteName = request.getNotePath(); revisionId = request.getRevisionId(); } AuthenticationInfo subject = new AuthenticationInfo(authenticationService.getPrincipal()); diff --git a/zeppelin-server/src/main/java/org/apache/zeppelin/rest/message/NewNoteRequest.java b/zeppelin-server/src/main/java/org/apache/zeppelin/rest/message/NewNoteRequest.java index 8a539f709df..6ee89d52adb 100644 --- a/zeppelin-server/src/main/java/org/apache/zeppelin/rest/message/NewNoteRequest.java +++ b/zeppelin-server/src/main/java/org/apache/zeppelin/rest/message/NewNoteRequest.java @@ -23,15 +23,14 @@ */ public class NewNoteRequest { - //TODO(zjffdu) rename it to be notePath instead of name - private final String name; + private final String notePath; private final String defaultInterpreterGroup; private final Boolean addingEmptyParagraph; private final List paragraphs; private final String revisionId; - public NewNoteRequest(String name, String defaultInterpreterGroup, Boolean addingEmptyParagraph, List paragraphs, String revisionId) { - this.name = name; + public NewNoteRequest(String notePath, String defaultInterpreterGroup, Boolean addingEmptyParagraph, List paragraphs, String revisionId) { + this.notePath = notePath; this.defaultInterpreterGroup = defaultInterpreterGroup; this.addingEmptyParagraph = addingEmptyParagraph; this.paragraphs = paragraphs; @@ -49,8 +48,8 @@ public boolean getAddingEmptyParagraph() { return addingEmptyParagraph.booleanValue(); } - public String getName() { - return name; + public String getNotePath() { + return notePath; } public String getDefaultInterpreterGroup() {