diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java index b19152df5ab..b23048ae9e1 100644 --- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java +++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java @@ -353,7 +353,6 @@ public Paragraph insertNewParagraph(int index, AuthenticationInfo authentication private Paragraph createParagraph(int index, AuthenticationInfo authenticationInfo) { Paragraph p = new Paragraph(this, this, factory, interpreterSettingManager); p.setAuthenticationInfo(authenticationInfo); - p.addUser(p, p.getUser()); setParagraphMagic(p, index); return p; } diff --git a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteTest.java b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteTest.java index 1c9cfc9d9a8..0eb37dfb5eb 100644 --- a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteTest.java +++ b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteTest.java @@ -217,4 +217,20 @@ public void getNameWithoutNameItself() { assertEquals("getName should return same as getId when name is empty", note.getId(), note.getName()); } + + @Test + public void personalizedModeReturnDifferentParagraphInstancePerUser() { + Note note = new Note(repo, interpreterFactory, interpreterSettingManager, jobListenerFactory, index, credentials, noteEventListener); + + String user1 = "user1"; + String user2 = "user2"; + note.setPersonalizedMode(true); + note.addNewParagraph(new AuthenticationInfo(user1)); + Paragraph baseParagraph = note.getParagraphs().get(0); + Paragraph user1Paragraph = baseParagraph.getUserParagraph(user1); + Paragraph user2Paragraph = baseParagraph.getUserParagraph(user2); + assertNotEquals(System.identityHashCode(baseParagraph), System.identityHashCode(user1Paragraph)); + assertNotEquals(System.identityHashCode(baseParagraph), System.identityHashCode(user2Paragraph)); + assertNotEquals(System.identityHashCode(user1Paragraph), System.identityHashCode(user2Paragraph)); + } }