Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Eagerly cancel rpc request #2380

Open
3 tasks done
summaryzb opened this issue Mar 6, 2025 · 0 comments · May be fixed by #2381
Open
3 tasks done

[Improvement] Eagerly cancel rpc request #2380

summaryzb opened this issue Mar 6, 2025 · 0 comments · May be fixed by #2381

Comments

@summaryzb
Copy link
Contributor

summaryzb commented Mar 6, 2025 •
edited
Loading

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Although needCancelRequest may cancel some work, but the AddBlockEvent in the blocking queue of threadPool still holds the shuffleblockdata, and the request that are already called still keep retring if encounter rpc fail

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@summaryzb summaryzb linked a pull request Mar 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#2380] Improvement: Eagerly cancel rpc request summaryzb/incubator-uniffle
1 participant
@summaryzb