[Relay] s/SEScope/VirtualDevice/g #9759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbs-octoml
requested review from
Hzfengsy,
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
kparzysz-quic,
masahi,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
electriclilies
approved these changes
Dec 16, 2021
Contributor
electriclilies
left a comment
electriclilies
left a comment
There was a problem hiding this comment.
Dang it! I really wanted it to be DeviceyMcDeviceFace. Oh well..
Nobody liked 'SEScope', and 'DeviceMcDeviceFace' is too verbose, so it seems 'VirtualDevice' has the popular vote.
mbs-octoml
force-pushed
the
mbs-sescope-rename
branch
from
07eb43c to
cb9ea2f
Compare
tqchen
approved these changes
Dec 17, 2021
Member
|
Thanks @mbs-octoml @electriclilies , might be good to also send a minor update to the SEScope RFC as well |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* [Relay] s/SEScope/VirtualDevice/g Nobody liked 'SEScope', and 'DeviceMcDeviceFace' is too verbose, so it seems 'VirtualDevice' has the popular vote.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* [Relay] s/SEScope/VirtualDevice/g Nobody liked 'SEScope', and 'DeviceMcDeviceFace' is too verbose, so it seems 'VirtualDevice' has the popular vote.
qsqqsqqsq-intellif
pushed a commit
to qsqqsqqsq-intellif/tvm
that referenced
this pull request
Apr 29, 2022
* [Relay] s/SEScope/VirtualDevice/g Nobody liked 'SEScope', and 'DeviceMcDeviceFace' is too verbose, so it seems 'VirtualDevice' has the popular vote.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nobody liked 'SEScope', and 'DeviceMcDeviceFace' is too verbose, so it
seems 'VirtualDevice' has the popular vote.