-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Python] Add library lookup path for tvm installed as a pakcage #18348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @mshr-h, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue preventing the TVM Python package from functioning correctly after installation. Previously, when TVM was installed as a package, it failed to locate its necessary shared libraries, leading to a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a library search path to address an issue with importing tvm when it's installed as a Python package. The change is a functional fix for the described problem. My review includes one comment that, while the change is effective, it may be a workaround for an underlying inconsistency in the build and installation process defined in CMake. Addressing the root cause in the CMake configuration would be a more robust long-term solution for better maintainability.
|
|
||
| # Pip lib directory | ||
| dll_path.append(ffi_dir) | ||
| dll_path.append(os.path.join(ffi_dir, "lib")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change effectively resolves the library loading issue. However, it appears to be a workaround for an underlying inconsistency in the installation process. It seems CMakeLists.txt has duplicate install directives for the tvm and tvm_runtime libraries, which can lead to them being placed in different directories based on the build context (e.g., pip install vs. a manual make install).
For better long-term maintainability, we should consider addressing the root cause in the CMake setup to ensure libraries are always installed to a single, predictable location. This would simplify the library discovery logic and make the packaging more robust.
As per title.
repro:
we get