[WASM] Implement concat embeddings #17404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2024
CharlieFRuan
added a commit
to mlc-ai/web-llm
that referenced
this pull request
Sep 23, 2024
### Changes - The only change is the support of Phi-3.5-vision: - #563 - Added `Phi-3.5-vision-instruct-q4f16_1-MLC` and `Phi-3.5-vision-instruct-q4f32_1-MLC` to prebuilt model list - See `examples/vision-model` on how to use vision language model in WebLLM ### TVMjs - Compiled at apache/tvm@931efc7 - Cherry-picked apache/tvm#17404 on top - Note this does not require us to recompile non-vision models because text-only inputs will not need embeddings concatenation - WASMs: still the same `v0_2_48` WASMs
tqchen
approved these changes
Sep 23, 2024
jingyi-zhao-01
pushed a commit
to jingyi-zhao-01/web-llm
that referenced
this pull request
Dec 8, 2024
### Changes - The only change is the support of Phi-3.5-vision: - mlc-ai#563 - Added `Phi-3.5-vision-instruct-q4f16_1-MLC` and `Phi-3.5-vision-instruct-q4f32_1-MLC` to prebuilt model list - See `examples/vision-model` on how to use vision language model in WebLLM ### TVMjs - Compiled at apache/tvm@931efc7 - Cherry-picked apache/tvm#17404 on top - Note this does not require us to recompile non-vision models because text-only inputs will not need embeddings concatenation - WASMs: still the same `v0_2_48` WASMs
atebites-hub
pushed a commit
to atebites-hub/web-llm
that referenced
this pull request
Oct 4, 2025
### Changes - The only change is the support of Phi-3.5-vision: - mlc-ai#563 - Added `Phi-3.5-vision-instruct-q4f16_1-MLC` and `Phi-3.5-vision-instruct-q4f32_1-MLC` to prebuilt model list - See `examples/vision-model` on how to use vision language model in WebLLM ### TVMjs - Compiled at apache/tvm@931efc7 - Cherry-picked apache/tvm#17404 on top - Note this does not require us to recompile non-vision models because text-only inputs will not need embeddings concatenation - WASMs: still the same `v0_2_48` WASMs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
tvmjs.runtime.ConcatEmbeddingsin C++ and exposes it toruntime.ts'sInstanceclass asconcatEmbeddings().The method takes in a vector of
NDArray, each arrayihas shape(m_i, hidden_size), returning an NDArray of shape(\sum_{i} {m}, hidden_size).Besides, this PR also:
stdfor WebGPU codegencopyFrom()'sdataargument to be different types of typed arraythis.dtype === uint32forcopyFrom()