[TVMScript][FIX] Disable show_object_address in printing by default
#15705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new feature of printing object addresses is introduced in apache#15579. It's an excellent feature for debugging, but it should not be turned on by default.
junrushao
approved these changes
Sep 8, 2023
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
LGTM. Looks like a small typo
Contributor
|
Thank you for the fix. This was intended to be disabled by default. |
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Sep 10, 2023
…apache#15705) The new feature of printing object addresses is introduced in apache#15579. It's an excellent feature for debugging, but it should not be turned on by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new feature of printing object addresses is introduced in #15579. It's an excellent feature for debugging, but it should not be turned on by default.
cc @Lunderberg @junrushao