Skip to content

Conversation

@ysh329
Copy link
Contributor

@ysh329 ysh329 commented Apr 24, 2023

This bumps all the version numbers on v0.12.0 branch as correct v0.12.0.

cc @driazati @Johnson9009 @junrushao

@tvm-bot
Copy link
Collaborator

tvm-bot commented Apr 24, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: release See #10317 for details

Generated by tvm-bot

@github-actions github-actions bot requested review from driazati and junrushao April 24, 2023 14:39
@ysh329
Copy link
Contributor Author

ysh329 commented Apr 24, 2023

So strange, log shows conflict as below:
image

@leandron
Copy link
Contributor

leandron commented Apr 24, 2023

So strange, log shows conflict as below:
image

I think this has to do with the fact that CI will try to git merge your current patch with "top of the repository", and as the top of the repository is now fixed to 0.13.dev0, it diverges from what you propose here.

So I don't think that there is anything wrong with your patch, we probably just need to fix CI somewhere. @driazati can you help?

@ysh329 ysh329 mentioned this pull request Apr 24, 2023
7 tasks
@driazati
Copy link
Member

driazati commented Apr 24, 2023

Yeah this is a CI problem, I think we should just disable that behavior for releases, I filed a PR to do it: #14715. Once that is merged into v0.12.0, we can rebase this PR and it should use the updated CI configs

@ysh329
Copy link
Contributor Author

ysh329 commented Apr 28, 2023

@tvm-bot rerun

@ysh329
Copy link
Contributor Author

ysh329 commented Apr 28, 2023

I rebase failed and re-PR with #14739 .

@ysh329 ysh329 closed this Apr 28, 2023
@ysh329 ysh329 deleted the modify-version-num-to-v0.12.0 branch April 28, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants