Skip to content

Conversation

@janetsc
Copy link
Contributor

@janetsc janetsc commented Mar 23, 2023

The unity branch has errors for deprecated APIs. Updating the codegen for Hexagon call from llvm::DataLayout::getTypeSizeInBits.getFixedSize() to llvm::DataLayout::getTypeSizeInBits.getFixedValue()

Verified this works on main as well.

cc: @farshidsp

@tvm-bot
Copy link
Collaborator

tvm-bot commented Mar 23, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@janetsc janetsc marked this pull request as ready for review March 23, 2023 22:56
@masahi
Copy link
Member

masahi commented Mar 30, 2023

@janetsc Can you send this to main? The change to unity should be specific to relax. We get the same change in unity after weekly rebase.

@janetsc
Copy link
Contributor Author

janetsc commented Mar 30, 2023

Done, created a PR for main, closing this one.

@janetsc janetsc closed this Mar 30, 2023
@janetsc janetsc deleted the unity_hexagon_build branch March 30, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants