Skip to content

[Hexagon] Allow scalar tensors to have null shape during allocation #14376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2023
Merged

[Hexagon] Allow scalar tensors to have null shape during allocation #14376

merged 2 commits into from
Mar 23, 2023

Conversation

@janetsc
Copy link
Contributor

@janetsc janetsc commented Mar 23, 2023 •
edited
Loading

Update assert during buffer allocation. Zero dimensional tensors (scalars) can have a null shape.

cc: @csullivan, @farshidsp

@tvm-bot
Copy link
Collaborator

tvm-bot commented Mar 23, 2023 •
edited
Loading

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@janetsc janetsc requested a review from Lunderberg March 23, 2023 15:13
@janetsc
Copy link
Contributor Author

janetsc commented Mar 23, 2023

@tvm-bot rerun

@janetsc janetsc changed the title [Hexagon] Allow scalar tensors to have null shape during allocation. [Hexagon] Allow scalar tensors to have null shape during allocation Mar 23, 2023
@janetsc
Copy link
Contributor Author

janetsc commented Mar 23, 2023

@tvm-bot rerun

@janetsc janetsc marked this pull request as ready for review March 23, 2023 19:39
csullivan
csullivan approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@csullivan csullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@csullivan csullivan merged commit 3b274aa into apache:main Mar 23, 2023
@ibsidorenko ibsidorenko mentioned this pull request Mar 29, 2023
Closed
@janetsc janetsc deleted the null_shape_scalar branch March 29, 2023 15:57
@ysh329 ysh329 mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csullivan csullivan csullivan approved these changes

@Lunderberg Lunderberg Awaiting requested review from Lunderberg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janetsc @tvm-bot @csullivan