[TVMC] Fix logging in TVMC #14175
Merged
[TVMC] Fix logging in TVMC #14175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
leandron
approved these changes
Mar 2, 2023
Contributor
Author
|
Sorry this fell off my radar for a bit - updated the patch now with a test to check that we set the |
Three logger related changes in this patch: * Currently we don't set the output stream on the Python logger, so it defaults to sys.stderr, which means we only get some logger output when the command fails. So set the output stream to sys.stdout * Currently we can add -v flag to anywhere in the command line for tvmc compile, but only between tvmc and run/tune for run and tune. Unify the behaviour such that we can add the flag anywhere on the command line. * Set the effective upper bound of -vs to 3 as 4 could result in NOTSET which would not output anything.
Change-Id: I49554e5bbac4332f1db8ad0c7fbfce4001dbf36a
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three logger related changes in this patch:
tvmc compile, but only betweentvmcandrun/tuneforrunandtune. Unify the behaviour such that we can add the flag anywhere on the command line.-vs to 3 as 4 could result in NOTSET which would not output anything.