Skip to content

Enhance the --help message of composite target #13842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Enhance the --help message of composite target #13842

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99e1ec0
Enhance the --help message of composite target
MNGanesan Jan 17, 2023
d080aac
Added decorator for the test case, which check command line help
MNGanesan Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/tvm/driver/tvmc/target.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def _generate_codegen_args(parser, codegen_name):
target_group.add_argument(
f"--target-{codegen_name}-{target_option}",
type=python_type,
help=f"target {codegen_name} {target_option}{python_type}",
help=field.description,
)


Expand Down
22 changes: 22 additions & 0 deletions tests/python/driver/tvmc/test_target_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,28 @@ def test_mapping_target_args():
assert reconstruct_target_args(parsed) == {"llvm": {"mcpu": "cortex-m3"}}


def test_composite_target_cmd_line_help():
parser = argparse.ArgumentParser()
generate_target_args(parser)
assert parser._option_string_actions["--target-vitis-ai-dpu"].help == "Vitis AI DPU identifier"
assert (
parser._option_string_actions["--target-vitis-ai-build_dir"].help
== "Build directory to be used (optional, debug)"
)
assert (
parser._option_string_actions["--target-vitis-ai-work_dir"].help
== "Work directory to be used (optional, debug)"
)
assert (
parser._option_string_actions["--target-vitis-ai-export_runtime_module"].help
== "Export the Vitis AI runtime module to this file"
)
assert (
parser._option_string_actions["--target-vitis-ai-load_runtime_module"].help
== "Load the Vitis AI runtime module to this file"
)


@tvm.testing.requires_cmsisnn
def test_include_known_codegen():
parser = argparse.ArgumentParser()
Expand Down