Skip to content

[BugFix][TVMScript]fix var capturing order error #13640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2022
Merged

[BugFix][TVMScript]fix var capturing order error #13640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd996e3
fix var capturing order error.
Dec 18, 2022
beedcb9
Make it easy to understand.
Dec 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/tvm/script/parser/core/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ def inspect_function_capture(func: Callable) -> Dict[str, Any]:
The function variables map with non-local or global variables.
"""
captured = {
**inspect.getclosurevars(func).nonlocals,
**func.__globals__, # type: ignore
**inspect.getclosurevars(func).nonlocals,
}
return captured

Expand Down
17 changes: 17 additions & 0 deletions tests/python/unittest/test_tvmscript_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,24 @@ def func_ref():
tvm.ir.assert_structural_equal(test_case, func_ref)


def test_var_capturing_order():
b = 2

@T.prim_func
def test_case():
k: T.int32 = b

@T.prim_func
def func_ref():
k: T.int32 = 2
T.evaluate(0)

tvm.ir.assert_structural_equal(test_case, func_ref)


if __name__ == "__main__":
a = numpy.zeros((10, 10), dtype="int8")
test_multi_element_array_in_outmost_namespace()
test_different_dtype_assignment_to_var()
b = 1
test_var_capturing_order()