Add python venvs to demo_ images that build #13435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
driazati
approved these changes
Nov 18, 2022
Member
driazati
left a comment
driazati
left a comment
There was a problem hiding this comment.
LGTM but is there any reason to not add this to every demo_ image? e.g. Dockerfile.demo_cpu, Dockerfile.demo_opencl, etc.
Contributor
Author
|
those ones use manual pip3 install commands, just fixing the ones that use the shared python install script for now |
areusch
force-pushed
the
tvm-venv-demos
branch
from
ed111a6 to
2a41a1e
Compare
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Add python venvs to demo_ images that build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13015. Note that vitis_ai is broken for another reason, so I couldn't test this fix, but I'll contribute it so that when vitis_ai is unbroken, the Python scripts should be on the right track.
@zuowanbushiwo @HadXu @driazati