Fix caffe, boost install in Python venvs by creating python3.X link #12828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
areusch
force-pushed
the
fix-venv-imports
branch
from
908c0e9 to
e46f1be
Compare
driazati
approved these changes
Sep 17, 2022
| PYCAFFE_ROOT=${CAFFE_HOME}/python | ||
| echo "${CAFFE_HOME}/lib" >> /etc/ld.so.conf.d/caffe.conf && ldconfig | ||
| VENV_SITE_PACKAGE=$(pip3 show numpy | grep "Location:" | cut -d ' ' -f 2) | ||
| ln -s ${PYCAFFE_ROOT}/caffe ${VENV_SITE_PACKAGE}/caffe |
Contributor
Author
There was a problem hiding this comment.
true, do you have a preference? cc @ashutosh-arm
Contributor
Author
There was a problem hiding this comment.
oh sorry, reading the CI failure now. ignore me :)
areusch
force-pushed
the
fix-venv-imports
branch
from
57a5a74 to
d0757bc
Compare
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…pache#12828) * Fix caffe, boost install in Python venvs by creating python3.X link. * Use getsitepackages()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some of the ongoing problems we're having building docker images after merging #12663 . It links
caffeinto the venv (this was done before, but is now done via the env var) and ensures that cmake will find the venv Python by ensuring that thepython3.7command resolves to the venv Python. Finally, it builds boost outside the venv so that development files can be found.@leandron @driazati