-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Added macro generation in MLF export #12789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 17 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
e28b949
Added macro generation in MLF export
fzi-peccia ff40652
Fixed tests
fzi-peccia cd33ca7
Fixed black formatting
fzi-peccia 7589796
Small lint fix
fzi-peccia d755cf0
Last lint fix
fzi-peccia 323500a
cpp lint fix
fzi-peccia fcb46ec
Fixed cpp tests
fzi-peccia 7014604
cpp lint improvements
fzi-peccia e312d8e
Fixed cpp tests
fzi-peccia c22f03d
cpp lint
fzi-peccia de52850
Update src/target/source/interface_c.cc
fPecc 475a0ab
Update src/target/source/interface_c.cc
fPecc 8bf30d4
Update src/target/source/interface_c.cc
fPecc a544a26
SanitizeName added and tests fixed
fzi-peccia df0854f
lint fixes
fzi-peccia 7e432e8
lint fix
fzi-peccia f6d707e
lint
fzi-peccia 80dc8e6
Merge branch 'main' into mlf-macro-gen
fzi-peccia 4e3a07f
requested improvements and tests changes
fzi-peccia f645a33
Improved format
fzi-peccia d25c4c8
Merge remote-tracking branch 'upstream/main' into mlf-macro-gen
fzi-peccia 91cf25a
Fixed failing tests
fzi-peccia b5bc50e
lint fix
fzi-peccia 97f0b5d
Removed unnecessary check
fzi-peccia 3931d0b
Removed unnecessary checks
fzi-peccia 107e482
Added macro generation in MLF export
fzi-peccia a210129
Fixed tests
fzi-peccia ef9c6a8
Fixed black formatting
fzi-peccia d768723
Small lint fix
fzi-peccia e6d8f08
Last lint fix
fzi-peccia da23330
cpp lint fix
fzi-peccia 62a6714
Fixed cpp tests
fzi-peccia d2f217d
cpp lint improvements
fzi-peccia 52f67fc
Fixed cpp tests
fzi-peccia c4233fc
cpp lint
fzi-peccia 4a863c3
Update src/target/source/interface_c.cc
fPecc 2802c1b
Update src/target/source/interface_c.cc
fPecc 8e8a4b2
Update src/target/source/interface_c.cc
fPecc c27c359
SanitizeName added and tests fixed
fzi-peccia 3391884
lint fixes
fzi-peccia 17b0cab
lint fix
fzi-peccia 7723957
lint
fzi-peccia 6c54eec
requested improvements and tests changes
fzi-peccia 1fd4b70
Improved format
fzi-peccia f782c9e
Fixed failing tests
fzi-peccia 0790d45
lint fix
fzi-peccia 307c724
Removed unnecessary check
fzi-peccia c9be298
Removed unnecessary checks
fzi-peccia 8468ade
Merge branch 'mlf-macro-gen' of github.com:fPecc/tvm into mlf-macro-gen
fzi-peccia fa16303
Merge remote-tracking branch 'upstream/main' into mlf-macro-gen
fzi-peccia 94934a6
Merge branch 'main' into mlf-macro-gen
fzi-peccia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a test case for when this is not set? How do we reproduce it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Mousius . I reviewed the code and noticed that the parameters of the primfuncs in the main_func_metadata always seem to have the checked_type set, so I removed the check here.