Skip to content

[Hexagon] [runtime] Improve runtime resource management #12727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 16, 2022
Merged

[Hexagon] [runtime] Improve runtime resource management #12727

merged 17 commits into from
Sep 16, 2022

Conversation

@janetsc
Copy link
Contributor

@janetsc janetsc commented Sep 7, 2022 •
edited
Loading

Improves runtime buffer management

  • Adds entry points to "acquire" and "release" resources in the device API object. These are called from the RPC client session object.
  • Adds a new buffer manager object for runtime allocations. It is created in Acquire and destroyed in Release.
  • Updates device API to use runtime buffer manager if it exists.
  • Unit test.

Future changes:

  • Add thread manager, dma engine

cc @areusch @mehrdadh

@janetsc janetsc changed the title WIP [Hexagon] [runtime] First pass at improving runtime resource management WIP [Hexagon] [runtime] Improve runtime resource management Sep 8, 2022
@janetsc janetsc changed the title WIP [Hexagon] [runtime] Improve runtime resource management [Hexagon] [runtime] Improve runtime resource management Sep 8, 2022
mehrdadh
mehrdadh reviewed Sep 8, 2022
View reviewed changes
Lunderberg
Lunderberg reviewed Sep 8, 2022
View reviewed changes
mehrdadh
mehrdadh reviewed Sep 8, 2022
View reviewed changes
JosephTheOctonaut
JosephTheOctonaut reviewed Sep 8, 2022
View reviewed changes
@janetsc janetsc marked this pull request as ready for review September 12, 2022 14:09
@janetsc janetsc closed this Sep 12, 2022
@janetsc janetsc reopened this Sep 12, 2022
@github-actions github-actions bot requested a review from areusch September 12, 2022 18:06
@janetsc janetsc marked this pull request as draft September 12, 2022 20:45
@janetsc janetsc marked this pull request as ready for review September 13, 2022 17:33
Lunderberg
Lunderberg reviewed Sep 14, 2022
View reviewed changes
@tmoreau89
Copy link
Contributor

tmoreau89 commented Sep 15, 2022

CC @kparzysz-quic for additional input; thanks!

areusch
areusch reviewed Sep 15, 2022
View reviewed changes
Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @janetsc , added a couple questions

adstraw
adstraw suggested changes Sep 16, 2022
View reviewed changes
adstraw
adstraw approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@adstraw adstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@areusch areusch merged commit 38f53e8 into apache:main Sep 16, 2022
@janetsc janetsc deleted the resource_management branch September 27, 2022 17:39
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@janetsc @xinetzone
[Hexagon] [runtime] Improve runtime resource management (apache#12727)
6e3e643 
* First pass at improving runtime resource management

* Add unit test

* Fix lint and clang format errors

* Disable resource reset for simulator

* Moved acquire/release calls to session object, separate buffer managers for non-runtime (static) and runtime (dynamic).

* Fix lint errors

* Fix lint errors

* Improve robustness of session shutdown

* Fix lint

* Address feedback

* Only allow call to Acquire in a clean state

* Use a pointer to indicate the "active" manager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lunderberg Lunderberg Lunderberg left review comments

@mehrdadh mehrdadh mehrdadh left review comments

@areusch areusch areusch approved these changes

+3 more reviewers

@cconvey cconvey cconvey left review comments

@JosephTheOctonaut JosephTheOctonaut JosephTheOctonaut left review comments

@adstraw adstraw adstraw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@janetsc @tmoreau89 @areusch @Lunderberg @cconvey @mehrdadh @adstraw @JosephTheOctonaut