[HEXAGON] Auto-vectorization (fp16) for v68 #12397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avquicinc
changed the title
Contributor
Author
|
Hi @kparzysz-quic, |
Member
|
@tvm-bot rerun |
cconvey
reviewed
Aug 17, 2022
| if not llvm_options: | ||
| llvm_options = "" | ||
| llvm_options += " -force-hvx-float" | ||
|
|
Contributor
There was a problem hiding this comment.
Does this flag impose any new requirements regarding which LLVM versions TVM needs?
Contributor
There was a problem hiding this comment.
Also, are there any potential downsides or other side-effects of using this flag? Asking because with compiler flags, the word "force" sometimes implies that the resulting behavior isn't always a good idea.
Contributor
There was a problem hiding this comment.
It will work with any LLVM version that supports v69. It's fine to use it.
Contributor
Member
|
@tvm-bot rerun |
kparzysz-quic
approved these changes
Aug 18, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* Auto-vectorization (fp16) for v68 * use tvm.testing.main in fp16 test of tanh_slice op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.
cc @mehrdadh