Skip to content

Conversation

@manupak
Copy link
Contributor

@manupak manupak commented Jun 24, 2022

This commit enables the striping for network tests.
Currently it requires, storage_rewrite to be run if
striping is enabled to produce correct results.

cc : @lhutton1 @ekalda @NicolaLancellotti

cc @Mousius

@manupak manupak force-pushed the micronpu_enable_striping_for_network_tests branch from 886b2cb to c470dde Compare June 26, 2022 09:29
@github-actions github-actions bot requested a review from Mousius June 26, 2022 09:29
@manupak manupak force-pushed the micronpu_enable_striping_for_network_tests branch from c470dde to 5f7c5a5 Compare June 27, 2022 07:45
@manupak
Copy link
Contributor Author

manupak commented Jun 27, 2022

@tvm-bot rerun

This commit enables the striping for network tests.
Currently it requires, storage_rewrite to be run if
striping is enabled to produce correct results.

Change-Id: I12b976bb77d339771f8b5a554817d192e7c99723
@manupak manupak force-pushed the micronpu_enable_striping_for_network_tests branch from 5f7c5a5 to df55139 Compare June 28, 2022 11:46
@manupak
Copy link
Contributor Author

manupak commented Jun 28, 2022

This is green now! :D

Copy link
Contributor

@ekalda ekalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhutton1 lhutton1 merged commit b733aa3 into apache:main Jun 28, 2022
@lhutton1
Copy link
Contributor

Thanks @manupa-arm, @ekalda!

blackkker pushed a commit to blackkker/tvm that referenced this pull request Jul 7, 2022
This commit enables the striping for network tests.
Currently it requires, storage_rewrite to be run if
striping is enabled to produce correct results.

Change-Id: I12b976bb77d339771f8b5a554817d192e7c99723
masahi pushed a commit to masahi/tvm that referenced this pull request Jul 15, 2022
This commit enables the striping for network tests.
Currently it requires, storage_rewrite to be run if
striping is enabled to produce correct results.

Change-Id: I12b976bb77d339771f8b5a554817d192e7c99723
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
This commit enables the striping for network tests.
Currently it requires, storage_rewrite to be run if
striping is enabled to produce correct results.

Change-Id: I12b976bb77d339771f8b5a554817d192e7c99723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants