[MetaSchedule] JSONDatabase Utilities #11680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrushao
force-pushed
the
feature/2022-06-10/database-utils
branch
from
9a41c70 to
f88709b
Compare
junrushao
force-pushed
the
feature/2022-06-10/database-utils
branch
from
f88709b to
cc6481d
Compare
Hzfengsy
approved these changes
Jun 11, 2022
Member
Hzfengsy
left a comment
Hzfengsy
left a comment
There was a problem hiding this comment.
LGTM.
Thank you, @junrushao1994, very much! It is beneficial when we apply tuning logs. The cost will reduce from a few minutes to only 10s!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some utility to JSONDatabase to accelerate its loading/saving time.