[TIR] IndexMap Simplification Constraints #11342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifications done when applying a transformation may require iteration bounds from the caller scope. This is a C++ only feature, because `arith::Analyzer` doesn't inherit from `ObjectRef`, and cannot be passed through the FFI.
Avoid needing to simplify twice, now that IndexMap can accept the analyzer from the calling scope.
masahi
approved these changes
May 17, 2022
Lunderberg
force-pushed
the
layout_transform_extract_functionality
branch
from
960415e to
0466426
Compare
Member
|
@Lunderberg |
Contributor
Author
|
Looks like it's a timeout, with both instances being terminated after around 2h08m. Looks like there's some bumps to the timeout during investigation. |
Iteration variables defined in `BlockNode::iter_vars` may be useful for simplifications. This functionality was extracted from `TransformLayoutRewriter`.
Lunderberg
force-pushed
the
layout_transform_extract_functionality
branch
from
0466426 to
6620f03
Compare
Contributor
Author
|
Bumped CI to restart, after #11350 merged. |
Contributor
|
Thanks @Lunderberg @masahi, this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up from #11330. I really like the functionality that it adds (simplification of transformed indices based on
BlockNodeiteration variables), and would like to expose the functionality for use elsewhere as well.