[Relay] Bug fix when applying history using an iterator or records. #11306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mbs-octoml this should fix the issue you ran into. I decided to go with more careful type checking rather than changing the append since I think this is a more intuitive way of handling both lists of (Input, Records) pairs and iterators over them. |
mbs-octoml
approved these changes
May 16, 2022
Contributor
mbs-octoml
left a comment
mbs-octoml
left a comment
There was a problem hiding this comment.
LGTM. String is Iterable!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a bug in #11199 that causes an error when an Iterator of records is used as the argument to ApplyHistoryBest. This small PR fixes it by more carefully checking input types.