[Hexagon] Remove sim_options from tvm.target.hexagon() #11293
Conversation
|
What do you mean by running simulator automatically here? |
|
In offload mode the runtime started the simulator without user's intervention. |
We no longer run simulator automatically, so this is not necessary. Also, the only way to pass options to the simulator was by setting an environment variable. That variable (HEXAGON_SIM_ARGS) should be set independently by the user from now on.
mehrdadh
left a comment
mehrdadh
left a comment
There was a problem hiding this comment.
LGTM!
cc @Lunderberg to take a look as well.
Lunderberg
left a comment
Lunderberg
left a comment
There was a problem hiding this comment.
LGTM!
The previous use of HEXAGON_SIM_ARGS to pass information between two parts of the same python process was a bit more mutable global state than I prefer, so I like the removal. As I understand it, the functionality that it added was to launch a simulation with matched parameters to the Target object. In the future, if we want to parametrizing the unit tests across multiple simulated hardware versions, this may be useful functionality to maintain, but probably by constructing the arguments in HexagonLauncherSimulator based on the target.
We no longer run simulator automatically, so this is not necessary. Also, the only way to pass options to the simulator was by setting an environment variable. That variable (HEXAGON_SIM_ARGS) should be set independently by the user from now on.
We no longer run simulator automatically, so this is not necessary. Also, the only way to pass options to the simulator was by setting an environment variable. That variable (HEXAGON_SIM_ARGS) should be set independently by the user from now on.
We no longer run simulator automatically, so this is not necessary. Also, the only way to pass options to the simulator was by setting an environment variable. That variable (HEXAGON_SIM_ARGS) should be set independently by the user from now on.
3 participants
We no longer run simulator automatically, so this is not necessary. Also, the only way to pass options to the simulator was by setting an environment variable. That variable (
HEXAGON_SIM_ARGS) should be set independently by the user from now on.cc @mehrdadh