[QNNParam] Refactor the implmentation of QNNParam #11011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewZhaoLuo
approved these changes
Apr 14, 2022
Contributor
AndrewZhaoLuo
left a comment
AndrewZhaoLuo
left a comment
There was a problem hiding this comment.
LGTM seems pretty harmless and more pythonic.
Contributor
|
I would recommend rebasing on |
…re friendly to Python 2.x.
billishyahao
force-pushed
the
refactorqnnparam
branch
from
e2d09dd to
b4dc91b
Compare
Lucien0
pushed a commit
to Lucien0/tvm
that referenced
this pull request
Apr 19, 2022
* The patch is to simplify the implmentation of QNNParam and make it more friendly to Python 2.x. * Empty-Commit * fix error about boolean value of Tensor with more than one value is ambiguous.
altanh
pushed a commit
to altanh/tvm
that referenced
this pull request
Apr 28, 2022
* The patch is to simplify the implmentation of QNNParam and make it more friendly to Python 2.x. * Empty-Commit * fix error about boolean value of Tensor with more than one value is ambiguous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch is to simplify the implmentation of QNNParam and make it more friendly to Python 2.x.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.