[ARM] Support NCHWc alter layout in the fallback mode #10724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
commented
Mar 23, 2022
| cfg = dispatch_ctx.query(target, workload) | ||
| if cfg.is_fallback: # if is fallback, clear query cache and return None | ||
| autotvm.task.clear_fallback_cache(target, workload) | ||
| return None |
Member
Author
There was a problem hiding this comment.
I hope it's safe to remove this. The x86 counterpart doesn't have thing like this.
Member
Author
There was a problem hiding this comment.
If I can pass the CI with this change, I assume it is safe.
There was a problem hiding this comment.
@Mousius - could you please look at this given you've recently been turning on topi tests on aarch64 ?
Member
Author
There was a problem hiding this comment.
I need to remove this code because it always makes alter_layout nop in the fallback mode. In contrast, in the x86 schedule, alter_layout always fires.
Member
Author
There was a problem hiding this comment.
The CI has passed. I found that Giuseppe's im2col based conv2d implementation can fail to tensorize in the fallback mode, so I partially restored the fallback return path above.
masahi
force-pushed
the
arm-conv2d-alter-op
branch
from
8acb02c to
a05d81f
Compare
tkonolige
approved these changes
Mar 23, 2022
Contributor
tkonolige
left a comment
tkonolige
left a comment
There was a problem hiding this comment.
Overall looks good except for a few small changes.
masahi
force-pushed
the
arm-conv2d-alter-op
branch
from
a05d81f to
0beacdf
Compare
Member
Author
junrushao
approved these changes
Mar 24, 2022
Mousius
reviewed
Mar 25, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* [ARM] Support NCHWc alter layout in the fallback mode * remove fallback path * add test * fixed int32_lanes and add channel check * fixed schedule dispatch bug * add workaround fallback path for NHWC im2col based GEMM schedule * int32_lanes=4 by default * typo * update test
Anndrey24
added a commit
to Anndrey24/tvm
that referenced
this pull request
Aug 17, 2023
…ts matrix for arm_cpu NHWC quantized conv2d Fixed arm_cpu strategy bug which was causing tensorization errors when using the `AlterOpLayout` pass for the quantized NHWC conv2d schedules, as discovered in apache#10724. Therefore, we can now also enable the usage of `AlterOpLayout` for these schedules in order to transform the weight matrix at compile time, instead of runtime as before. I also modified the padding in `Conv2DGemmWeightTransformRel` and `interleave_transpose_weights` to reflect the changes made in apache#13669 and updated the AlterOpLayout tests accordingly.
lhutton1
pushed a commit
that referenced
this pull request
Aug 23, 2023
…ts matrix for arm_cpu NHWC quantized conv2d (#15584) Fixed arm_cpu strategy bug which was causing tensorization errors when using the `AlterOpLayout` pass for the quantized NHWC conv2d schedules, as discovered in #10724. Therefore, we can now also enable the usage of `AlterOpLayout` for these schedules in order to transform the weight matrix at compile time, instead of runtime as before. I also modified the padding in `Conv2DGemmWeightTransformRel` and `interleave_transpose_weights` to reflect the changes made in #13669 and updated the AlterOpLayout tests accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to extract tuning tasks for ARM int8 tensorization. The current
alter_layoutcode intopi/arm_cpudoesn't fire in the fallback mode, which has been fixed in the PR.@tkonolige @comaniac