[CMSIS-NN] Scalar to tensor constant pass to support only qnn.add and qnn.multiply #10563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Luke Hutton <[email protected]> Change-Id: If9cb41d0dd3f56666b6a2c0d9903502d3f9e4eae
asparkhi
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
manupak,
mbaret,
merrymercy,
tqchen,
trevor-m,
yzhliu and
zhiics
as code owners
Contributor
Author
Change-Id: I67250a6214a2d54ef07d54d84eac4ce91474bb0e
Contributor
Author
|
Thanks @manupa-arm. PTAL - I have added another commit with review suggestions. |
manupak
approved these changes
Mar 14, 2022
Contributor
manupak
left a comment
manupak
left a comment
There was a problem hiding this comment.
LGTM! thanks @ashutosh-arm
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
… qnn.multiply (apache#10563) * Scalar to tensor constant pass to support qnn.add and qnn.multiply only. Co-authored-by: Luke Hutton <[email protected]> Change-Id: If9cb41d0dd3f56666b6a2c0d9903502d3f9e4eae * Created a function to check if an expr is worthy of pass Change-Id: I67250a6214a2d54ef07d54d84eac4ce91474bb0e Co-authored-by: Luke Hutton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed scalar to tensor constant pass:
-Scalar to tensor pass to support qnn.add and qnn.multiply.
-Fixed application of the pass for non primary operands.
-Moved tests to check for int8 types specifically.